Add decoder attempt instance #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Can you please add a simple test? |
|
Btw. as there are not that many contributors, I suggest to push branches directly to this repo. |
matejcerny
approved these changes
May 30, 2024
|
@matejcerny let me add tests then 👍 |
geirolz
force-pushed
the
add-decoder-attempt
branch
from
2727981
to
80a16fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a decoder provides an implicit attempted-version. Useful to control how to ack a broken message instead of letting the stream collapse
#313 mentioned the problem, this is a solution that let the user to manually ack the broken messages ( choosing between NAck or Reject )
P.S. Potentially we could also add the
Optionversion